[Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28133





--- Comment #8 from Eric Seidel <eric at webkit.org>  2009-08-10 09:43:09 PDT ---
(From update of attachment 34478)
Sorry, didn't mean for it to sound like something you'd need to "surrender" to.
:)

We tend to avoid using PassRefPtr on the stack, as it's error prone.  Instead
we use a RefPtr and just call .release() when we need the PassRefPtr out of it.

I'm not sure why grabbing the CanvasPixelArray out of in1/in2 wouldn't be a
function:
102     // Get PixelArray of m_in2
 103     filterContext->drawImage(m_in2->resultImage()->image(),
calculateDrawingRect(m_in2->subRegion()));
 104     imageData = resultImage()->getImageData(imageRect);
 105     PassRefPtr<CanvasPixelArray> srcPixelArrayB(imageData->data());

imageDataAsPixelArray(m_in2);

I'm also not sure if you're intending to re-use the ImageData pointer from
m_in2 during your calculations or not.  Is that intended?  I assume you're
trying to avoid allocating a new buffer just to hold the result data?
 125             imageData->data()->set(pixelByteOffset + channel, result);
Can you just write directly to resultImage()?

In general this looks great though.

Why don't you need to clear the filterContext before drawing m_in?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.