[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 09:03:59 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #80 from Yong Li <yong.li at torchmobile.com>  2009-08-10 09:03:56 PDT ---
Going to create a new bug for this. Just want to mention:

(In reply to comment #57)
> 
> > +    Vector<JSAMPLE, 2048> rowBuffer;
> > +    if (setjmp(err.setjmp_buffer)) {
> > +        jpeg_destroy_compress(&compressData);
> > +        return false;
> > +    }
> > +
> > +    jpeg_start_compress(&compressData, TRUE);
> > +
> > +    rowBuffer.resize(compressData.image_width * 3);

> Why not declare rowBuffer just above this last line?

I just remember that this is necessary. If I declare rowBuffer below "setjmp",
then when the block in "setjmp" is reached, the destructor of rowBuffer won't
be called. So it leaks. going to add a comment

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list