[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #78 from Yong Li <yong.li at torchmobile.com>  2009-08-10 07:58:10 PDT ---
(In reply to comment #77)
> (In reply to comment #76)
> > (In reply to comment #69)
> > > (From update of attachment 34394 [details] [details] [details])
> > All ports use BitmapImage class, including WINCE port. But platform image type
> > (defined as "NativeImagePtr") is still required. On Windows platform, it can be
> > HBITMAP. SharedBitmap is a replacement of HBITMAP, and is more flexible and
> > useful than HBITMAP.
> > 
> > I don't think this basic acknowledge of WebCore should go to ChangeLog. I've
> > mentioned NativeImagePtr in there, and I think people who are familiar with
> > WebCore image stuff can understand it with no problem.
> 
> I'm about as familiar with WebKit Images as you can expect from a reviewer. :) 
> I've worked on the Image stuff several times, including the most recent
> re-factoring splitting out BitmapImage from Image.   Why does WinCE need a
> NativeImagePtr Image wrapper and other ports don't?  I guess other ports use
> BitmapImage to wrap their NativeImagePtr, no?
> 

#if PLATFORM(WX)
class wxBitmap;
class wxGraphicsBitmap;
#elif PLATFORM(CG)
typedef struct CGImageSource* CGImageSourceRef;
typedef struct CGImage* CGImageRef;
typedef const struct __CFData* CFDataRef;
#elif PLATFORM(QT)
#include <qglobal.h>
QT_BEGIN_NAMESPACE
class QPixmap;
QT_END_NAMESPACE
#elif PLATFORM(CAIRO)
struct _cairo_surface;
typedef struct _cairo_surface cairo_surface_t;
#elif PLATFORM(SKIA)
class NativeImageSkia;
#elif PLATFORM(WINCE)
#include "SharedBitmap.h"
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.