[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #76 from Yong Li <yong.li at torchmobile.com>  2009-08-10 07:44:35 PDT ---
(In reply to comment #69)
> (From update of attachment 34394 [details])
> The ChangeLog really should have more information on what these classes are
> for, what they do.  Why does the WinCE port use this new "SharedBitmap" and
> what is it for?  It seems ImageBufferData is just to allow ImageBuffer to be
> backed by a SharedBitmap, the question is why? ;)  Likewise BufferedImage seems
> to exist so that Image can be backed by a ImageBufferData.  Why wouldn't WinCE
> have used the BitmapImage abstraction that other classes use?  Image exists to
> abstract between SVGImage, PDFDocumentImage and BitmapImage.  Seems you have
> created a duplicate/parallel BitmapImage-like subclass, no?
> 
> (Not necessarily giving objection here, just seeking more information!) :)
> 
> Need more info in the ChangeLog to perform a good review.  Also, I think given
> how comment-full this bug is now, these patches really should be each on their
> own bugs so they can be discussed where folks have some prayer of being able to
> read all the relevant comments. :)
> 

All ports use BitmapImage class, including WINCE port. But platform image type
(defined as "NativeImagePtr") is still required. On Windows platform, it can be
HBITMAP. SharedBitmap is a replacement of HBITMAP, and is more flexible and
useful than HBITMAP.

I don't think this basic acknowledge of WebCore should go to ChangeLog. I've
mentioned NativeImagePtr in there, and I think people who are familiar with
WebCore image stuff can understand it with no problem.

If we need more description to help new webkit developers understand webkit
source code, ChangeLog is not a good place to hold it.

(BTW, could you please give more info to bug 28019 why you think it's a wrong
approach?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.