[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #74 from Yong Li <yong.li at torchmobile.com>  2009-08-10 07:32:59 PDT ---
(In reply to comment #71)
> (From update of attachment 34398 [details])
> Neat that you wrote your own Path implementation.  Sad that you had to. :(
> 
> We avoid using "default:" when switching enums so that the compiler can catch
> modifications to that enum/missing case statements:
> 15     //case PathCloseSubpath:
>  316     default:
> 

Not all ports use same compiler. I've seen some coding rules (not webkit one)
saying "default:" should always present in a switch block, and like this idea.
In this case, the compiler won't generate code to compare the value with
PathCloseSubpath. Condition checks are expensive on ARM. Probably I should add
ASSERT ( ... == PathCloseSubpath); after "default:". Then that looks perfect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.