[Webkit-unassigned] [Bug 28063] LayoutTests/http/tests/appcache/max-size.html fails - vacuum should happen after setting max size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28063


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34360|review?                     |review-
               Flag|                            |




--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-08-09 22:20:11 PDT ---
(From update of attachment 34360)
Ok.  So this looks fine.  Need one more round though.

We need a comment next to the code noting that the order is important.  The
ChangeLog (and possibly the code comment) should ideally reference the SQLite
docs which say that order matters here.

Again, the change looks totally fine.  The point I'm going for is that we
should make sure that we make sure that no one will get this wrong again. :)
(When they re-factor the code for instance.)

If you were a committer, I would just r+ this and you could fix it when you
land.  Since you aren't, i'm going to ask that you post one more patch.

Thanks again for the patch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.