[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 9 21:59:27 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #71 from Eric Seidel <eric at webkit.org>  2009-08-09 21:59:25 PDT ---
(From update of attachment 34398)
Neat that you wrote your own Path implementation.  Sad that you had to. :(

We avoid using "default:" when switching enums so that the compiler can catch
modifications to that enum/missing case statements:
15     //case PathCloseSubpath:
 316     default:

I would have broken "contains" up into static-inline helper functions.

Again here:
65     //case PathCloseSubpath:
 466     default:

Indent:
 472 : m_penLifted(true)

I'll have to read this more closely later.  Probably needs its own bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list