[Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 9 21:40:45 PDT 2009


--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-09 21:40:45 PDT ---
(From update of attachment 34430)
You're going to want to mark your unknown/lighten/darken etc as "static" so
that compilers know they shouldn't have external linkage.

Seems you should name your arguments here:
 33 typedef void (*BlendType)(double, double&, double, double);

Maybe that should return a double instead of taking a double& for colorB?

Should be "static const BlendType const" so compilers know those jump locations
aren't gonna change.
 108     BlendType callEffect[] = {unknown, normal, multiply, screen, darken,

In general this looks good though!  I think you should get oliver to review
this, as his graphics expertise is far better than mine. :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list