[Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 9 11:28:55 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28122





--- Comment #7 from Ryan Leavengood <leavengood at gmail.com>  2009-08-09 11:28:53 PDT ---
(In reply to comment #5)
> 
> ColorSkia? I do not want to sound boring, but there is no such file.

I don't see that either.

> In fact I was wrong, I can't cast an unsigned (RGBA32) to a struct of unsigned
> (rgb_color). So it would still use the make_color function.

Are you sure? Doing a cast instead of calling a function would probably be
faster and I'm sure this conversion would need to be done a lot.

Eric, our rgb_color struct is defined here:

http://svn.berlios.de/viewcvs/haiku/haiku/trunk/headers/os/interface/GraphicsDefs.h?revision=25797&view=markup

Since this is C++ code the rgb_color struct is essentially a public class, so
maybe it can't be just cast even if the members are in the same order (then of
course there is endianness, which may also be an issue, right?)

I am not particularly skilled at the moment on these low-level types of issues
(too much Ruby, HTML and JavaScript these last few years), so any insight is
appreciated.

Also in regards to all the BRect and IntRect stuff, that probably does need an
audit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list