[Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28122





--- Comment #5 from Maxime Simon <simon.maxime at gmail.com>  2009-08-09 10:35:57 PDT ---
(In reply to comment #2)
> (From update of attachment 34407 [details])
> What does the color struct look like?  Could you just use a COMPILE_ASSERT to
> assert identical layout with the WebCore:RGBA32 type and not need to call
> make_color, etc?
> 
> See how I did things in ColorSkia (where we just cast directly).  Your current
> solution is *totally fine*.  I just wanted to bring the opportunity of casting
> directly to your attention.

ColorSkia? I do not want to sound boring, but there is no such file.
In fact I was wrong, I can't cast an unsigned (RGBA32) to a struct of unsigned
(rgb_color). So it would still use the make_color function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.