[Webkit-unassigned] [Bug 28087] [Chromium] Mods for a chrome specific impl of ApplicationCacheHost

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28087





--- Comment #2 from Michael Nordman <michaeln at google.com>  2009-08-09 09:48:56 PDT ---
Fyi: I've intentionally  chosen to use the PLATFORM flag here to help clarify
what parts of the appcache system are actually in the CHROMIUM port. The
majority of the appcache directory is not, a few files are...

* ApplicationCacheHost.h
* DOMApplicationCache.idl .h .cpp

Using the PLATFORM() flag in this .h file is reflective of that, and while it
may not make it crystal clear what classes/files are relevant to CHROMIUM, it
does provide big clues that ApplicationCacheGroup and familiy don't apply.

My thinking is that having this reflected in the .h file helps with
maintainability.

I'd be willing to shuffle some more deck chairs around to create a
ApplicationCacheHostInternal class that inter-operates with
ApplicationCacheGroup and family (and removes the PLATFORM flag), but for the
reason stated above, I don't think that would be an improvement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.