[Webkit-unassigned] [Bug 28121] [Haiku] Modifications on JavaScriptCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28121





--- Comment #4 from Ryan Leavengood <leavengood at gmail.com>  2009-08-09 08:32:58 PDT ---
Eric,

We are definitely interested in improving the general WebKit code as well as
having our port code done "better". In this case some more details on what
exactly you are looking for would help.

It seems like even if we added a ThreadingHaiku.cpp and a new static inline
method to get the stack base there would still need to be an #elif
PLATFORM(HAIKU) in currentThreadStackBase in Collector.cpp.

I suppose the best solution is to move all the associated thread stack base
code for all platforms in their respective Threading* classes and then just
call that function from Collector.cpp. I suppose that would be your "ideal"
solution, right?

Of course there are no files ThreadingSolaris, ThreadingSymbian, ThreadingBSD,
ThreadingWinCE, or ThreadingHaiku yet. It seems like the stack base needs to be
abstracted out at another level maybe. Or ThreadingPthreads can just have
#ifdefs for the various pthread platforms to get the stack base in all those
ways. Maybe WinCE could be stuck in with ThreadingWin, since ThreadingWin would
need at least 3 #ifdefs as it is for the stack base.

It is definitely a tricky problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.