[Webkit-unassigned] [Bug 28129] [Haiku] Adding three new files to WebCore/platform/haiku.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28129


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34419|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-09 08:26:29 PDT ---
(From update of attachment 34419)
No need to do explicit string construction here:
 37     return String("Submit");

return "Submit";
works just as well and is less to type/read.

 32 void InitializeLoggingChannelsIfNecessary()

probably needs a FIXME About how it really should read the logging config from
a file.

I'm surprised this method name violates modern webkit style:
 32 void InitializeLoggingChannelsIfNecessary()
maybe it's just so old...?

Are you sure this is right?
 151     fontDescription.setIsAbsoluteSize(true);
 152     fontDescription.setGenericFamily(FontDescription::NoFamily);
 153    
fontDescription.setSpecifiedSize(static_cast<int>(be_plain_font->Size()));
That seems wrong.  last-resort fallback fonts are determined by font family.  I
also would have expect you to set a font face name there.
Also, that's completely ignoring the various CSS values passed in...

Why create a new theme for each page?
PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
 180 {
 181     if (page)
 182         return RenderThemeHaiku::create();
 183 
 184     static RenderTheme* fallback =
RenderThemeHaiku::create().releaseRef();
 185     return fallback;
 186 }
You don't seem to store any state on the themes.  SEems all pages should just
use the "fallback".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.