[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #61 from Yong Li <yong.li at torchmobile.com>  2009-08-09 07:22:31 PDT ---
(In reply to comment #59)
> (In reply to comment #58)
> > > > +struct jpeg_dest_mgr {
> > > > +    struct jpeg_destination_mgr pub;
> > > > +    Vector<char> buffer;
> > > > +    Vector<char>* dump;
> > > > +};
> > > 
> > > Naming style (here and below)
> > 
> > I see { should be in the next line here. I'm told that "m_" should not be used
> > for "struct"
> 
> Based on http://webkit.org/coding/coding-style.html , the struct name should be
> CamelCase (with the first letter capitalized), and the members should have m_
> (I don't see an exception for structs and haven't heard this before).  Also the
> names should be more descriptive than "dest_mgr" or "pub"; use full words where
> possible.
> 

The struct name "jpeg_dest_mgr" follows libjpeg style. The existing
JPEGImageDecoder.cpp does the same:

struct decoder_error_mgr {
    struct jpeg_error_mgr pub;  /* "public" fields for IJG library*/
    jmp_buf setjmp_buffer;      /* For handling catastropic errors */
};

About "m_" for the members in struct: this is a good example that one reviewer
says this, but another says opposite. Sigh...

I'm going to use:

class JpegDestinationManager
{
public:
    Foo m_foo;
    ...
};

Will anyone say that the data member shouldn't be public? or suggest me to
change back to struct?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.