[Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27967


Michael Nordman <michaeln at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaeln at google.com




--- Comment #7 from Michael Nordman <michaeln at google.com>  2009-08-08 20:17:56 PDT ---
File: WebCore/storage/SQLTransaction.cpp

329             if (m_transactionClient)
392     if (m_transactionClient)
426     if (m_modifiedDatabase && m_transactionClient)

There are a few tests for m_transactionClient being null in this file. Are
those really needed, are there any situations where the client is expected to
be null? (It looks like there aren't). And if there are no valid situations for
a null client... maybe ASSERT(transClient) in the ctor.

File: WebCore/ChangeLog
34         * storage/SQLTransactionClient.cpp: Added.
35         (WebCore::SQLTransactionClient::databaseChanged):
36         (WebCore::SQLTransactionClient::databaseSizeChanged):
37         (WebCore::SQLTransactionClient::databaseExceedsQuota):

I think when adding new files, the preference is to not list all of the newly
added methods. For changes to existing files, its useful to see specifically
which methods changed, but not so for newly added files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.