[Webkit-unassigned] [Bug 28114] [ES5] Implement Object.getPrototypeOf

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28114


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34399|review?                     |review+
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-08 17:19:21 PDT ---
(From update of attachment 34399)
Do we want to guard this in any way?  I don't know how up-in-the-air ES5 is at
this point.

Technically this looks fine.

I guess isPrototypeOf was implemented before but just not well tested? (Since I
don't see the implementation of isPrototypeOf here.

Since this technically looks fine, and I trust you to make a guarding decision,
r+. :)  (I even went and read the spec.)

You might consider adding the spec text to your ChangeLog:

15.2.3.2 Object.getPrototypeOf ( O ) 
When the getPrototypeOf function is called with argument O, the following steps
are taken: 
1. If Type(O) is not Object throw a TypeError exception. 
2. Return the value of the [[Prototype]] internal property of O.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.