[Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 12:11:58 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27543


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34385|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #43 from Eric Seidel <eric at webkit.org>  2009-08-08 12:11:58 PDT ---
(From update of attachment 34385)
An interesting approach. :)

Indent:
 41 : m_impl(other.m_impl)
 46 : m_impl(CursorNone)
 61 : m_impl(c)

Normally we don't use "get" in function names.  I might have named it
cursorForType(type) instead.

I've never seen a .cpp file use single-line function declarations like that
before.  But I also don't think it's harmful.

OK.  Please fix the indent nit on landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list