[Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27202





--- Comment #12 from Joseph Pecoraro <joepeck02 at gmail.com>  2009-08-08 11:08:59 PDT ---
(In reply to comment #4)
> Leaving a note while I think of it:  I should be a lot more careful when I
> delete a cookie to escape any quotes... since this passes through an eval. 

Done. I escape quotes.

(In reply to comment #8)
> You should describe more about the change in the ChangeLog.

Done. And the correct files now!

> You should add you and not Apple on all new files.

Done. Added myself for Cookie.js and both Apple + myself on CookiesItemView.js
due to similar code.

> You should[n't] need to make a new DataGrid subclass just for this method. Can the
> CookieItemsView just handle this one thing?

Done.

> No need for the braces. No need for the spaces.

Done. Including many other style fixes.

> I know this matches how the other data grids are made, but I think this should
> be up to the views. This model was done for databases so two views could share
> code. But some day we should make DatabasesPanel a very slim Panel subclass
> that just manages the sidebar and active view.

Done. Moved the bulk of the cookie code into the view.

(In reply to comment #1)
> - The Cookie TreeElement disappears if the user has the Inspector open and
> navigates to another page or reloads the current page.  I don't know which
> functions the Inspector is calling.  It doesn't seem to call the Panel's show()
> or populateInterface() methods on page loads, only when the currentPanel is
> changed to the Databases panel or the WebInspector is opened after being
> closed.

This is still a minor problem.

> - The Datagrid has the ability to delete cookies and will automatically update
> the display once a cookie has been deleted.  Again this jumps into the
> inspected window to run a command.

Deleting isn't perfect yet. I have to "guess" the Cookie's path, so I attempt
both an empty path and the "/" path.  This should be solved with a C++ version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.