[Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27428





--- Comment #15 from Xan Lopez <xan.lopez at gmail.com>  2009-08-08 10:13:07 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> 
> > Ideally, this patches would've been r-'d due to the issues you raised. But if
> > Luke is willing to provide a follow-up patch to fix those issues, 
> 
>  yes of course - that was always the plan.
> 
>  ... _after_ the whole series of [what will later today become 30] patches is
> in.
> 
>  as a separate, distinct, self-contained, managed, easy-to-manage, controlled
> and reviewed patch.
> 
>  in this way, it's possible to go in incremental verifiable steps.
> 
>  basically, changing Gdom to Webkit etc. is a g/s/r whitespace change.
> 
>  you _never_ mix in whitespace changes in with code changes.

This patch is nothing but boilerplate, there is nothing to it but the naming.
If you are not even willing to do trivial changes that we already agreed to do
in order to get your patches upstream I'm not sure what are we doing here
exactly.

> 
>  so - land gdom first; whitespace next.  otherwise: mess, and lost history.
> 
>  remember - the current revision history for the gobject bindings isn't in
> webkit svn... it's in http://github.com/lkcl/16401.master.
> 
>  l.
> 
>  p.s. of course, anyone _else_ is welcome to:
> 
>  a) take over the maintenance of this work
>  b) provide the whitespace patch now
>  c) provide the whitespace patch later.
> 
> if nobody is willing to help, i'm choosing c.

Fair enough, I'll roll it out. A comment about the patch, for the future:

- There is no need to add a finalize method if the only thing you are doing is
chaining up to your parent class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.