[Webkit-unassigned] [Bug 28095] [WINCE] W3C Geolocation backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 07:41:12 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28095


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34364|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-08-08 07:41:11 PDT ---
(From update of attachment 34364)
This looks sane, non-harmful. :)  I've never worked with our geolocation code
before, so I am not able to help in that way.

I've not seen m_hFoo used to designate that foo is a handle.  Normally we would
write out Handle in the name if necessary.  Or we would have a HandlePtr that
new how to close in the destructor.  Sadly HandlePtr doesn't exist yet. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list