[Webkit-unassigned] [Bug 28063] LayoutTests/http/tests/appcache/max-size.html fails - vacuum should happen after setting max size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 21:25:37 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28063





--- Comment #7 from Martin Robinson <martin.james.robinson at gmail.com>  2009-08-07 21:25:37 PDT ---
Sorry. Let me try to clarify this. This test failed for me during the GTK+
tests, but has passed for others. I looked over the sqlite docs and it appears
that according to the documentation, the order of these operations:

    WebCore::cacheStorage().empty();
    WebCore::cacheStorage().vacuumDatabaseFile();
    WebCore::cacheStorage().setMaximumSize(size);

should really be:

    WebCore::cacheStorage().empty();
    WebCore::cacheStorage().setMaximumSize(size);
    WebCore::cacheStorage().vacuumDatabaseFile();

Making that change caused my GTK+ test to pass. The test passes both before and
after the same change is made to the CF port on my Macbook. The CF Mac port
seems to be the only other port that does a vacuum when changing the maximum
database size. The Qt port also does a .setMaximumSize(...) but never calls
vacuum.

I'm new to this, so I'm not sure how I should structure the patch. It's clear
that this fixes the test for my version of sqlite, but it's unclear why it was
passing in the first place and why it only passes on some versions of sqlite.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list