[Webkit-unassigned] [Bug 28060] bugzilla-tool needs a --quiet option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 18:51:56 PDT 2009


--- Comment #6 from Adam Barth <abarth at webkit.org>  2009-08-07 18:51:55 PDT ---
(In reply to comment #4)
> (From update of attachment 34310 [details])
> I'm not sure this is the best way to ignore output.  Not I've used
> .communicate() and ginored the results in other places.

I've changed to the communicate() way.  That wastes memory because the output
ends up in memory, but (1) I don't think it matters here and (2) we'll probably
wan the contents in memory to report errors later.

> Python has a ternary operator.  You better sit down before you read it though:
> child_stdout = open(os.devnull, "w") if quiet else None

Whatever.  Fixed.

> Why not just print before every subcommand?
> print "build-webkit..."
> I don't really like the "..."

Done.  Well, run-webkit-tests doesn't get a print, but it makes enough noise on
its own even with --quiet.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list