[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #46 from Yong Li <yong.li at torchmobile.com>  2009-08-07 15:14:08 PDT ---
(In reply to comment #44)
> (In reply to comment #43)
> > (In reply to comment #36)
> > > (From update of attachment 33815 [details] [details] [details])
> > > No ChangeLog.  r-
> > > 
> > > Please have George review your patches before posting again.  As demonstrated
> > > by the previous 2 patches, these are not ready for real review yet and posting
> > > them for review with George at least looking at them is just wasting other
> > > folks time.  George should be helping his contractors to follow the WebKit
> > > process, not depending on reviewers to teach you all.
> > 
> > I can review all I want but they're here because other people should see them. 
> > I'm not a babysitter and I don't work for you.  If it's such a problem, don't
> > review them and leave them for someone else.
> 
> I don't work for you either. :)  You are paying these people to contribute to
> WebKit.  The WinCE patches have been an undue burden on the WebKit review queue
> as of late. I know, because I just read through it twice in 2 days and
> reviewed most of the 50 bugs we just closed out. :)
> 
> I just ask that you work with the people you hire to improve the quality of
> patches posted to the review queue.  I'm very happy to review patches form the
> WinCE folks.  I just ask that they have a prayer of passing review before being
> posted.  In the case of this bug none of the patches even had ChangeLogs, let
> alone passing WebKit style.  In other bugs much of my r-ing of WinCE patches
> was about copy/paste code and patch size.
> 
> It seems that at least the lack of ChangeLogs, style issues
> (check-webkit-style) and patch size should be easy for you to work with the
> people you've hired to work on WebKit to solve.  Just as I work actively with
> the Google contributers to make sure that they are following WebKit process. :)
> 
> Thanks for your understanding.

The ChangeLog is all in the first patch. Peter Kasting has pointed out that we
should split the ChangeLog into different patches. We're going to do that
anyway. But the source files are still good to review. Recently we post a lot
of patches for WINCE port, because we have worked on this for more than 1.5
years, and just started upstreaming. But we don't expect that they can be
committed in short time. We're not pushing you. But this kind of review ( r-
with "No ChangeLog" ) won't take more than 0.5 min, right? Thanks for reviewing
and commenting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.