[Webkit-unassigned] [Bug 28080] Adding a bunch of Haiku-specific files for WebCore.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 14:43:24 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28080


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34319|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-08-07 14:43:24 PDT ---
(From update of attachment 34319)
In general "cs" is not a good variable name.  Please refer to the webkit style
guidelines for variable naming.

 62     color_space cs = screen.ColorSpace();

This looks OK though, and not worth another round of review for just that.

Thank you for splitting these up, it makes reviewing *much* easier. :) (and
much less waiting time for you).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list