[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33814|review?                     |review-
               Flag|                            |




--- Comment #35 from Eric Seidel <eric at webkit.org>  2009-08-07 14:35:42 PDT ---
(From update of attachment 33814)
r- for lack of ChagneLog.

Please run check-webkit-style.

g_ is not a pattern we use:
 static SharedBitmap::DrawPatternFunc g_drawPattern = 0;
 52 static SharedBitmap::DrawImageFunc g_drawImage = 0;


This can't be the only place in the project we need this?
 54 static inline int stableRound(double d)
please look for other implementations.

What is this class even for?  Please explain in a ChagneLog.

Why crateInstance instead of create?
 77 PassRefPtr<SharedBitmap> SharedBitmap::createInstance(bool is16bit, int w,
int h, bool initPixels)

Indent:
SharedBitmap::SharedBitmap(const BitmapInfo& bmpInfo, HBITMAP hbmp, void*
pixels)
 88 : m_bmpInfo(bmpInfo)
 89 , m_locked(false)
 90 

Please have george review your patches before posting again.  These are not
nearly ready.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.