[Webkit-unassigned] [Bug 28060] bugzilla-tool needs a --quiet option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 14:31:20 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28060


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34310|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-08-07 14:31:19 PDT ---
(From update of attachment 34310)
I'm not sure this is the best way to ignore output.  Not I've used
.communicate() and ginored the results in other places.

Python has a ternary operator.  You better sit down before you read it though:

child_stdout = open(os.devnull, "w") if quiet else None

Why not just print before every subcommand?
print "build-webkit..."
I don't really like the "..."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list