[Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27967


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34296|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-08-07 14:21:06 PDT ---
(From update of attachment 34296)
I need more background in the ChangeLog here.  Why are we doing this?  So that
Chromium can have the TransactionClient in a separate process?

0 seems like the wrong default here:
 71                                              PassRefPtr<VoidCallback>,
PassRefPtr<SQLTransactionWrapper>, SQLTransactionClient* transactionClient =
0);

I would think that we would want transactions to "work out of the box" for
webkit clients.  it seems possible here to construct a transaction which would
not work correctly out of the box!

Style:
 48 void SQLTransactionClient::databaseSizeChanged(Database* database) {

Why is a copy needed here?
 59     RefPtr<SecurityOrigin> origin = database->securityOriginCopy();

In general the chagnge looks fine.  I'm concerned about the =0 default.  I also
need more background in teh ChangeLog about why we're doing this (I'm not
opposed to it, but the ChangeLog needs to document our reasoning.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.