[Webkit-unassigned] [Bug 27794] [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo selector, new appearance, and new control part for the list attribute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27794


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33697|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-08-07 13:52:34 PDT ---
(From update of attachment 33697)
No { }:
 if (part == ListButtonPart) {
 337         [buttonCell setBezelStyle:NSRoundedDisclosureBezelStyle];
 338     } el

Tabs:
47         case ListButtonPart:
 448     {
 449             LengthSize result = sizeFromFont(font,
LengthSize(zoomedSize.width(), Length()), zoomFactor, buttonSizes());
 450             result.setWidth(result.height());
 451             return result;
 452     }

Where are the tests?

Parts of this at least should be guarded by some sort of DATALIST define. 
Otherwise this looks OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.