[Webkit-unassigned] [Bug 27787] The type information about the resource loading is not forwarded to the network layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27787


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33682|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-08-07 13:50:51 PDT ---
(From update of attachment 33682)
r- for lack of ChangeLog.

Please run check-webkit-style.

I think this should just be an argument to the constructor, but I can see how
that would be harry to add given the current design.

Please don't add a default here:
+    default : 
+        m_resourceType = GenericRequest;
+        break;
it defeats the point of using a switch for an enum (which is to catch when
something is added to the enum).

Never used, and not needed:
+        void setResourceType(RequestType type) { m_resourceType = type; }

Hum... but Platform can never depend on WebCore. So this is a layering
violation.

I suggest that instead you make CachedResource use these constants.  And then
CachedResource can cast its own constancts back to these for setting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.