[Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27734


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34307|review?                     |review-
               Flag|                            |




--- Comment #24 from Eric Seidel <eric at webkit.org>  2009-08-07 13:45:21 PDT ---
(From update of attachment 34307)
Are you sure that min<int> will compile on other platforms?  I feel like we've
dealt with the min/max issue on windows before in other ways.  Please grep the
source to see how it's dealt with elsewhere.

This needs a why comment:
29 #if !PLATFORM(WINCE)
227230     mutable SCRIPT_CACHE m_scriptCache;
228231     mutable SCRIPT_FONTPROPERTIES* m_scriptFontProperties;
229232 #endif
your note about it saving space in the ChangeLog is a fine comment, just put it
in teh soruce code too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.