[Webkit-unassigned] [Bug 27492] Web Sockets Test Infrastructure Part 3/3: Example test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27492


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34056|review?                     |review-
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-08-07 13:01:44 PDT ---
(From update of attachment 34056)
Great that these are js tests!  Bad that you had to copy the files.  We really
should  fix bug 25915 instead.

ChangeLog is duplicated.

 13     debug('<span class="pass">TEST COMPLETE</span>');
is instead a testPassed() call.

Style:
 if (window.layoutTestController) {
 4     window.layoutTestController.waitUntilDone();
 5 }

description() is the right call here:
debug("NOOP Web Socket test");

r- for various nits above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.