[Webkit-unassigned] [Bug 28078] WebInspector: Move object properties read / write access into InjectedScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28078


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34309|review?                     |review-
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-08-07 13:01:35 PDT ---
(From update of attachment 34309)

> -WebInspector.ObjectPropertiesSection = function(object, title, subtitle, emptyPlaceholder, ignoreHasOwnProperty, extraProperties, treeElementConstructor)
> +WebInspector.ObjectRef = function(objectId, path, protoDepth)

I think this should go into a new file and not ObjectPropertiesSection.js,
since it is used in other places and not specific to the
ObjectPropertiesSection.

I am not too fond of the Ref suffix. Do you like ObjectProxy better?

> +    this.objectId = objectId;

You should add a comment about this, this looks temporary.

> +    this.path = path || [];

> +InjectedScript._objectForId = function(objectId)
> +{
> +    return objectId;
> +}

You hould add a comment about this being temporary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.