[Webkit-unassigned] [Bug 27491] Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 12:57:00 PDT 2009


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #34055|review?                     |review-
               Flag|                            |

--- Comment #7 from Eric Seidel <eric at webkit.org>  2009-08-07 12:57:00 PDT ---
(From update of attachment 34055)
Please abstract:
8         my $testPath = "$testDirectory/$test";
 639         if (isCygwin()) {
 640             $testPath = toWindowsPath($testPath);
 641         } else {
 642             $testPath = canonpath($testPath);
 643         }

This is bad practice:
 1474     mkdir "/tmp/WebKit";

It make it harder to run more than one copy in parallel.  Better to use a ~
relative path or at least a unique name.  I'm certain there are other examples
of such in run-webkit-tests.

That's a huge amount of code to make sure the server is dead.  Don't we already
have some of that for the httpd server?  Can't we share that?

r- for the needed abstraction.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list