[Webkit-unassigned] [Bug 27431] splitting CodeGeneratorGObject.pm into library files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27431


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34289|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-08-07 12:04:01 PDT ---
(From update of attachment 34289)
This looks like a big hack.  If we're going to do this, lets do it right.  No
commented out code.  No long lists of exclusions.  Nicely named methods which
actually follow WebKit style guidlines.  Small files that reviewers have a
chance of understanding.  Detailed ChangeLogs.  Use of sets/hashes instead of
long lists of copy/paste ifs.  

As is, either you're just looking for a rubber-stamp.  Or you don't realize how
much patches like this are just a waste of time.

Glad to have you contributing.  But if you're going to contribute to a product
as mature as WebKit, you need to expect to take a bit longer on your patches,
and write mature, well structured patches instead of hacks.

Contributing to a large project like WebKit is a lot of work. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.