[Webkit-unassigned] [Bug 26949] WebCore part of the Haiku WebKit port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26949





--- Comment #40 from Maxime Simon <simon.maxime at gmail.com>  2009-08-07 12:00:41 PDT ---
> What is this and why?
>  // Fix temp routine to check the conversion works, please move it ASAP    
>  44 int charUnicodeToUtf8(unsigned short glyph, char* out)
> 
> It's not mentioned in the ChangeLog.  I needs a more decriptive name if it's
> just a hack.

I'm not sure about this function. I would like Ryan to explain it. (If he wrote
it.)

> convertUTF16ToUTF8RenderingHACK or something.

This may be a possibility.

> No hungarian notation here ;)
>  66     bool bFound = false;
>  67     bool bItalic = fontDescription.italic();
>  68     bool bBold = fontDescription.weight() == FontWeightBold;
> We ain't no microsoft...

Erk, it comes from the Syllable port. Ryan tried to avoid them as much as
possible but there may have some remains.

> Use the height of the X, can't you ask the font for the height of a glyph at a
> certain size?
>  52         m_xHeight = font->Size(); // Not sure about this

This was an issue I avoided when improving the port.
But I should update this patch.

> This information should be on the BFont:
>  53         m_unitsPerEm = 1; // FIXME!

The BFont (from Haiku) don't handle this.

> You'd have more luck posting this in smaller pices.  Some of this was just
> fine, but some of the font code is wrong here too.  If you broke it out, I
> coudl more easily approve the OK parts.

I think I will fill a new bug with multiple patches from this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.