[Webkit-unassigned] [Bug 25406] -webkit-box-orient:horizontal doesn't work on <button> tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25406


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32520|review?                     |review-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2009-08-07 09:32:00 PDT ---
(From update of attachment 32520)
In general this looks fine.

Is it possible to make a dumpAsText test for this instead?

Should "isBox" be isFlexibleBox?

Why shouldn't this check be moved inside createAnonymousBlock?
 55         bool isBox = style()->display() == BOX || style()->display() ==
INLINE_BOX;

r- for now, pending comments.  Feel free to set it back to r=? when you answer!
:)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.