[Webkit-unassigned] [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 09:26:13 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24300


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32098|review?                     |review-
               Flag|                            |




--- Comment #24 from Eric Seidel <eric at webkit.org>  2009-08-07 09:26:11 PDT ---
(From update of attachment 32098)
I thought the QWebHistoryInterface interface was deprecated?  I know that
WebKit qt has some hacks in place around the WebCore link hashing system just
to support this interface.  Seeems we should not be using it from DRT if
something better is available.

Style:
 92     DRTHistory *historyManager;

Leaked:
 154     historyManager = new DRTHistory(m_page);

You tests shoudl ideally e dumpAsText, since all they need to do is check the
computedStyle, they don't need to dump the pixels for the page to confirm this
change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list