[Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28064


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34258|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-07 08:40:40 PDT ---
(From update of attachment 34258)
It is not immediately apparent to me what was wrong in the table code.  Please
explain in your ChangeLog.

I like how the line spacing was where you copied this from:
+    style()->getBoxShadowExtent(shadowTop, shadowRight, shadowBottom,
shadowLeft);
+    m_overflowLeft = min(m_overflowLeft, shadowLeft);

I would prefer there was a line between the shadow lookups and the first
m_overflowLeft setting.

r- because your ChangeLog isn't clear enough (or my eyes aren't good enough) to
understand easily what this does besides moving code.

This change looks GREAT!  But I need to know (and future people looking at your
patch need to know) what is changed for Table/Flexbox.  A simple pointer in the
ChangeLog to what the error in the old code was would suffice.

Thanks for doing this!  Such a fantastic cleanup. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.