[Webkit-unassigned] [Bug 28067] TransformationMatrix should have rectToRect convenience function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28067


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34271|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-08-07 08:05:50 PDT ---
(From update of attachment 34271)
Does this have the desirable behavior when from.width() or from.height() is 0?

This does not match the pattern of other functions that manipulate the matrix.
For example, we don't have a function to return the identity matrix. Instead we
have a setter, makeIdentity(). Probably this should be makeRectToRect() or
makeIdentity() should be changed.

We don't have any other static member functions to create new matrices. And in
classes where we do have such functions we normally use the word "create" in
the name of the function.

Seems OK to add it.

I'm going to say r=me, but I think the class's interface is a little weak and
getting a little weaker.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.