[Webkit-unassigned] [Bug 27768] SVG feComponentTransfer needs to be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27768


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33662|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-08-06 19:24:04 PDT ---
(From update of attachment 33662)
Sad that we don't have a Color based get/set:
5         srcPixelArray->get(pixelByteOffset, r);
 196         srcPixelArray->get(pixelByteOffset + 1, g);
 197         srcPixelArray->get(pixelByteOffset + 2, b);
 198         srcPixelArray->get(pixelByteOffset + 3, a);

This should just be an array of these function pointers:
168         switch (channel) {
 169             case 0:
 170                 transferFunction = redFunction();
 171                 break;
 172             case 1:
 173                 transferFunction = greenFunction();
 174                 break;
 175             case 2:
 176                 transferFunction = blueFunction();
 177                 break;
 178             case 3:
 179                 transferFunction = alphaFunction();
 180                 break;
 181             default:
 182                 break;
 183         }

probably quicker than a switch, and much, much less code. :)

We need to find a way to share more of these for loops.

I think that we should use function pointers indexed in an array by
transferFunction.type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.