[Webkit-unassigned] [Bug 27305] [WINCE] add WinCE-specific unicode implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27305


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34225|review?                     |review-
               Flag|                            |




--- Comment #12 from Eric Seidel <eric at webkit.org>  2009-08-06 18:25:35 PDT ---
(From update of attachment 34225)
Style:
1     const UChar *sourceIterator = source;
 82     const UChar *sourceEnd = source + sourceLength;
 83     UChar *resultIterator = result;
 84     UChar *resultEnd = result + resultLength;

Argument names which don't provide clarity should be removed from headers per
our style:
 160         bool isSpace(wchar_t c);
 161         bool isLetter(wchar_t c);
 162         bool isPrintableChar(wchar_t c);
 163         bool isUpper(wchar_t c);
 164         bool isLower(wchar_t c);
 165         bool isPunct(wchar_t c);
 166         bool isDigit(wchar_t c);

I assume these are already covered by other tests?

Thank you very much for posting this much smaller patch.

Unless george is volunteering to fix these when landing, I'm going to r- this
and ask you to post a copy with fixed style since you don't have commit-bit yet
(to my knowledge).

You will find the "check-webkit-style" script helpful in validating that the
style is correct in these files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.