[Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27920


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33934|review?                     |review-
               Flag|                            |
  Attachment #33934|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-06 18:03:14 PDT ---
(From update of attachment 33934)
Looks fine.

Your if should use == LefButton (if that exists), or a comment to explain that
0 is the left button.

Style viloation:
1                 if (window.eventSender)
 12                 {

If you were a committer I would just r+ and you could fix this when landing. 
Since I don't think you are, please re-post with the two above fixes

--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-08-06 18:03:14 PDT ---
(From update of attachment 33934)
Looks fine.

Your if should use == LefButton (if that exists), or a comment to explain that
0 is the left button.

Style viloation:
1                 if (window.eventSender)
 12                 {

If you were a committer I would just r+ and you could fix this when landing. 
Since I don't think you are, please re-post with the two above fixes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.