[Webkit-unassigned] [Bug 27909] WebKit cannot decode jpegs that are in CMYK or YCCK format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27909


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33957|review?                     |review-
               Flag|                            |




--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-08-06 17:59:58 PDT ---
(From update of attachment 33957)
This does not follow WebKit style.  Maybe it's not supposed to?

spacing:
 481         dest.setRGBA(x, info->output_scanline - 1, c*k/255, m*k/255,
y*k/255, 0xFF);

spacing:
 513             JSAMPLE *j1 = samples[0];

extra { }:
2         } else if (info->out_color_space == JCS_CMYK) {
 523             cmyk_convert_rgb(buffer, *samples, info);
 524         } else {

See:
http://webkit.org/coding/coding-style.html

check-webkit-style should also help you.

Seems cmyk_convert_rgb should ASSERT output colorspace is JCS_CMYK?

You should consider throwing the rgb stuff in a similar static inline.

r- for the style violiations (or lack of informations as to why we would not
want to match WebKit style in this file).  please run check-webkit-style, there
is a diff option I'm told.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.