[Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with <table>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 14:46:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28017


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34133|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-06 14:46:21 PDT ---
(From update of attachment 34133)
If you're going to edit the generated template like this, you need to also
modify make-js-test-wrappers so ignore your .js file so that it doens't try to
re-gen a new version every time someone else runs make-js-test-wrappers.  (Yes,
I know this is all very poorly documented.)

Seems silly to leave this in the output:
 You should see no red.
 16 div:
 17 
 18 flexbox:
 19 
 20 table:
 21 

If you wrap it all in a div, you can easily remove that div before ending your
script.

Otherwise the change looks fine to me.

r- for those nits.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list