[Webkit-unassigned] [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 10:32:12 PDT 2009


Norbert Leser <norbert.leser at nokia.com> changed:

           What    |Removed                     |Added
  Attachment #34180|review?                     |
               Flag|                            |
  Attachment #34180|0                           |1
        is obsolete|                            |
  Attachment #34212|                            |review?
               Flag|                            |

--- Comment #4 from Norbert Leser <norbert.leser at nokia.com>  2009-08-06 10:32:09 PDT ---
Created an attachment (id=34212)
 --> (https://bugs.webkit.org/attachment.cgi?id=34212)
2nd update of patch file for bug #27059

I agree with Darin'd comment of trying to avoid redefining variables with
beginning double underscores in the library code.

How about this updated patch:
Since on Symbian, we detect the __EABI__ variable but not __ARM_EABI__, I
simply added that flag to the respective (negative) conditional statements.
It's only in 2 places and I assume it is safe for any other platforms that may
or may not have this flag set.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list