[Webkit-unassigned] [Bug 26993] [commit+] Geolocation::requestPermission()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26993





--- Comment #12 from Yong Li <yong.li at torchmobile.com>  2009-08-06 09:08:19 PDT ---
(In reply to comment #11)
> If I've followed the comments correctly, this change is intended to support
> both synchronous and asynchronous implementations of
> requestGeolocationPermissionForFrame().
> 
> I think, however, that this patch introduces a bug in the case where
> requestGeolocationPermissionForFrame() is synchronous. setIsAllowed() calls
> geolocationServicePositionChanged(), so if
> requestGeolocationPermissionForFrame() is synchronous, any watches will be
> called back twice, rather than once as intended.
> 
> See https://bugs.webkit.org/show_bug.cgi?id=27690 (which is a duplicate of this
> bug) for a full explanation.

I don't think it's a problem, because:

void Geolocation::requestPermission()
{
    if (m_allowGeolocation > Unknown)
        return;

...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.