[Webkit-unassigned] [Bug 28010] New: willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 4 19:02:56 PDT 2009


           Summary: willCacheResponse tests should be split from the main
                    dumpResourceLoadCallbacks() dumps
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: beidson at apple.com

willCacheResponse tests should be split from the main
dumpResourceLoadCallbacks() dumps.

>From email on webkit-dev:

On Aug 4, 2009, at 5:35 PM, Darin Fisher wrote:

There is a Mac-only willCacheResponse notification that gets recorded by
several of the layout tests when
layoutTestController.dumpResourceLoadCallbacks(true) is called.  However, this
notification which originates at the ResourceHandle level is currently #if
PLATFORM(MAC).  I noticed that the tests which depend on this notification are
currently skipped on platform/win.  For Chromium, we have simply rebaselined
with the willCacheResponse events excluded.  Having a separate baseline is
unfortunate and not running the tests on platform/win seems even worse.

I wonder if it wouldn't be better to exclude willCacheResponse by default, and
then only enable it selectively for tests that are about testing it.  That way,
we can un-skip the other tests that only fail on non-Mac as a side-effect of
this notification not being supported.  We could also try to support
willCacheResponse on all platforms, but that seems like a lot of work for
little gain.  Afterall, it is a notification that WebKit doesn't itself care
about.  It is just something provided to the embedder of the WebKit Framework
on Mac.

I didn't see any bugs on file about this issue.


My reply:

willCacheResponse was lumped in with dumpResourceLoadCallbacks() solely for
convenience based on the situation at the time.

As you point out, it is only interesting for embedders of mainline WebKit on

My two proposals are to either split off a new dumpWillCacheResponse() callback
or change dumpResourceLoadCallbacks() to take a second argument that is false
by default.

I slightly prefer the latter.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list