[Webkit-unassigned] [Bug 28003] New: Cleanup: ResourceResponse should be a class, not a struct

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28003

           Summary: Cleanup: ResourceResponse should be a class, not a
                    struct
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: michaeln at google.com


This 'struct' really should be a 'class'.

Here's how things are defined for various ports...

 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\cf\ResourceRequest.h(37):
   struct ResourceRequest : ResourceRequestBase {
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\curl\ResourceRequest.h(36):
   struct ResourceRequest : ResourceRequestBase {
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\qt\ResourceRequest.h(38):
   struct ResourceRequest : ResourceRequestBase {
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\soup\ResourceRequest.h(36):
   struct ResourceRequest : ResourceRequestBase {
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\chromium\ResourceRequest.h(38):
   struct ResourceRequest : public ResourceRequestBase {
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\mac\ResourceRequest.h(41):
   class ResourceRequest : public ResourceRequestBase {

Here's how many of the forward declarations are declared...

  C:\chrome\1\src\third_party\WebKit\WebCore\history\HistoryItem.h(53):struct
ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\inspector\InspectorController.h(67):struct
ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\inspector\InspectorResource.h(54):
   struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\loader\appcache\ApplicationCache.h(45):struct
ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\loader\appcache\ApplicationCacheHost.h(51):
   struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\loader\DocumentThreadableLoader.h(42):
   struct ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\loader\FrameLoaderClient.h(65):   
struct ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\loader\MainResourceLoader.h(43):  
 struct ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\loader\SubresourceLoader.h(36):   
struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\loader\SubresourceLoaderClient.h(36):struct
ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\loader\ThreadableLoader.h(41):   
struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\loader\WorkerThreadableLoader.h(50):
   struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\cf\ResourceRequestCFNet.h(33):
   struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\ResourceHandleClient.h(53):
   struct ResourceRequest;
 
C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\ResourceRequestBase.h(49):
   struct ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\platform\CrossThreadCopier.h(44): 
  struct ResourceRequest;
  C:\chrome\1\src\third_party\WebKit\WebCore\xml\XMLHttpRequest.h(37):struct
ResourceRequest;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.