[Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27490


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34053|review?                     |review-
               Flag|                            |




--- Comment #6 from Mark Rowe (bdash) <mrowe at apple.com>  2009-08-04 13:07:14 PDT ---
(From update of attachment 34053)
Two big issues jump out at me:
1) Coding style.  Python code in WebKit typically follows the standard Python
style guidelines as documented in PEP 8 at
http://www.python.org/dev/peps/pep-0008/.  This includes using four spaces for
indentation, lower_case_and_underscores for function and method names, and so
forth.  I think we're more than happy to ignore the 80 character line length
limit as we do elsewhere in WebKit source.
2) The script have a hardcoded #! line that refers to Python 2.4.  Tiger only
ships with Python 2.3, so a test harness will need to be compatible with that
version.  I've not studied the code closely enough to determine whether there
are 2.4 features used in the code or if it's just the shebang line that is the
problem.

The "websocket_" prefix on the file names also seems redundant given that this
all lives inside a websocket directory.

I'll try and take a closer look at the substance of the patch soon, but it's
clear at this point that it needs revision.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.