[Webkit-unassigned] [Bug 27885] Add QNX as supported platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 4 08:13:38 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27885





--- Comment #1 from Simon Hausmann <hausmann at webkit.org>  2009-08-04 08:13:37 PDT ---
(From update of attachment 33880)

The patch looks good to me, but I'm wondering about the hunk below:

> @@ -544,8 +567,9 @@ static inline void* currentThreadStackBa
>  #endif
>          int rc = pthread_attr_getstack(&sattr, &stackBase, &stackSize);
>          (void)rc; // FIXME: Deal with error code somehow? Seems fatal.
> -        ASSERT(stackBase);
>          pthread_attr_destroy(&sattr);
> +#endif
> +        ASSERT(stackBase);
>          stackThread = thread;
>      }
>      return static_cast<char*>(stackBase) + stackSize;

Why did you move the ASSERT? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list